Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pps override, this will cause a thread safety issue #1705

Closed
wants to merge 1 commit into from
Closed

fix pps override, this will cause a thread safety issue #1705

wants to merge 1 commit into from

Conversation

leyu-yao
Copy link
Contributor

Please do not merge it now. We may need more discussion.

@leyu-yao leyu-yao changed the title fix pps override, this will cause a thread racing fix pps override, this will cause a thread safety issue Jul 27, 2023
@1proprogrammerchant
Copy link

when can we merge it

@XinfengZhang XinfengZhang mentioned this pull request Aug 6, 2023
Closed
@leyu-yao
Copy link
Contributor Author

when can we merge it

This patch can fix this issue but not preferred. This issue is actually fixed in 2b40e2730
This PR is not needed now.
I'm going to close this PR soon.

@leyu-yao leyu-yao closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leyu-yao @1proprogrammerchant